Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OverlappingMarkerSpiderfier to plugins table #2036

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

Conengmo
Copy link
Member

@Conengmo Conengmo commented Nov 27, 2024

I was looking at the added documentation for the new OverlappingMarkerSpiderfier plugin and noticed it wasn't added to the table on the plugins page. See https://python-visualization.github.io/folium/dev/user_guide/plugins.html. Add it in this PR.

Perhaps the reason why it wasn't there is because the contributing guideline is not explicit enough on this topic. So update that guide as well.

@Conengmo
Copy link
Member Author

@swtormy do you maybe want to take a look, see if you agree with the line for your plugin, and if the updated guide is clear?

@swtormy
Copy link
Contributor

swtormy commented Nov 27, 2024

@swtormy do you maybe want to take a look, see if you agree with the line for your plugin, and if the updated guide is clear?

Yeah, it's all clear.

@Conengmo Conengmo merged commit 0734af4 into python-visualization:main Nov 27, 2024
10 of 11 checks passed
@Conengmo Conengmo deleted the plugin-table branch November 27, 2024 17:58
@Conengmo
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants