Add event handlers to the Draw plugin #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansthen
force-pushed
the
add_event_handlers_to_drawn_layers_in_draw_plugin
branch
from
73b616a to
a2c9292
Compare
This makes the draw plugin more dynamic. It allows the user to add `JsCode` event handlers to the generated layers.
hansthen
force-pushed
the
add_event_handlers_to_drawn_layers_in_draw_plugin
branch
from
3e53b86 to
c787898
Compare
hansthen
changed the title
Conengmo
requested changes
Oct 17, 2024
requirements.txt
Outdated
| numpy | ||
| numpy==1.* |
There was a problem hiding this comment.
please include this in a separate PR (if necessary)
| """ | ||
| ''' |
There was a problem hiding this comment.
I'm pretty sure Black uses double quotes? Why include this change?
Conengmo
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the draw plugin more dynamic. It allows the user to add
JsCodeevent handlers to the generated layers.Also removed duplicate actions for the "draw:created" event.