-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix streamlit-folium incompatibility (add layer to map with new class) #1834
Fix streamlit-folium incompatibility (add layer to map with new class) #1834
Conversation
Works for me ! |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
@ocefpaf when you have a moment, could you make a v0.15.1 release please? I already put an update in the changelog: https://github.com/python-visualization/folium/blob/main/CHANGES.txt |
@ocefpaf, if you have time to do the release before the end of next week it could help me quite a lot for my project actually :) |
I think all relevant code to publish to PyPI is in our Github Actions, so I'll give it a try to bake a release later today. |
I can do this today and I'll write a guide so others can do it in my absence. |
Sounds good @ocefpaf, thank you! |
Done! I thought I broke GHA last time but it was in top condition, so all we have to do is:
|
Perfect @ocefpaf, very clear! To be sure, I'll announce any new release in advance. Let's also stop updating [edit] to be sure we can find this guide again I posted it to the wiki: https://github.com/python-visualization/folium/wiki/How-to-make-a-release |
Fix the compatibility issue between Folium 0.15.0 and streamlit-folium, see randyzwitch/streamlit-folium#148.
When adding layers to the map, don't add the relevant code to the figure object. Instead, add a new class instance to the Layer instance. That way it will get rendered even if only the map and not the figure is being rendered. This is also maybe a bit nicer, since it's more in line with how the rest of Folium works.