-
Notifications
You must be signed in to change notification settings - Fork 2.2k
ENH: support xyzservices #1498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: support xyzservices #1498
Conversation
Looking at your management of built-in tiles, there's a possibility to simplify all that by relying on In It would require having It is up to you. I can either expand this PR or make the refactor in another one if you'd like to have it. |
xyzservices 2021.08.0 is now available on PyPI so the tests should now pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice integration. Let's merge it when the tests pass.
Additionally, we might want to include an example in our Quickstart example notebook or perhaps a separate notebook.
Do you want it to be a part of this PR or a follow-up? |
Let's do it as a follow-up, since this one is good to go! |
Closes #1497
The PR is ready, we just need to wait for xyzservices 2021.08.0 to be released as it currently requires functionality available only on main. That shouldn't take more than a couple of days.