Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow pre-/post-processing of arguments repr for logging. Fix #5 #13

Merged
merged 2 commits into from
May 1, 2018
Merged

Allow pre-/post-processing of arguments repr for logging. Fix #5 #13

merged 2 commits into from
May 1, 2018

Conversation

penguinolog
Copy link
Collaborator

  • Internal class BoundParameter and function bind_args_kwargs
  • public pre_process_param and post_process_param for override
    in subclass for special cases
  • *.pyi still python3.5+ (no 3.6 features used)

Related issue number

#5

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 337

  • 70 of 70 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 336: 0.0%
Covered Lines: 456
Relevant Lines: 456
💛 - Coveralls

2 similar comments
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 337

  • 70 of 70 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 336: 0.0%
Covered Lines: 456
Relevant Lines: 456
💛 - Coveralls

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 337

  • 70 of 70 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 336: 0.0%
Covered Lines: 456
Relevant Lines: 456
💛 - Coveralls

@coveralls
Copy link
Collaborator

coveralls commented Apr 30, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 338

  • 71 of 71 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 336: 0.0%
Covered Lines: 457
Relevant Lines: 457
💛 - Coveralls

@penguinolog
Allow pre-/post-processing of arguments repr for logging. Fix #5
09c2dd4 
* Internal class `BoundParameter` and function `bind_args_kwargs`
* public `pre_process_param` and `post_process_param` for override
  in subclass for special cases
* *.pyi still python3.5+ (no 3.6 features used)
@penguinolog
Expand BoundParameter to public for better typing and less misunderstand
a24cdf8 
`BoundParameter` is used internally for logwrap
and accessible in override methods.
`bind_args_kwargs` also expanded and documented.
@penguinolog penguinolog merged commit b5cac93 into python-useful-helpers:master May 1, 2018
@penguinolog penguinolog deleted the override branch May 1, 2018 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espositocloud espositocloud espositocloud approved these changes

@dis-xcom dis-xcom Awaiting requested review from dis-xcom dis-xcom is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@penguinolog @coveralls @espositocloud