Example client handle close #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This optional scope is cancelled when the connection is closed.
If the server closes the connection, the client will quit immediately rather than waiting for the next user command on stdin.
|
Closing this because I merged #55 as the preferred alternative to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one possible solution to #22: add an optional
cancel_scopeargument to client connections. When the connection is closed, the scope is cancelled. This allows, among other things, the example client to exit immediately when the server closes the connection. Previously, the example client would block on waiting for command line input and would not notice the connection dropped until it tried to perform the next command.