Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add asyncio/anyio taskgroup support to async111&112, update contributing.md #241

Merged
merged 2 commits into from
May 3, 2024

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented May 1, 2024

Fixes 2/3 tasks in #215

The logic in Visitor112 is incredibly messy and ugly, but works. Might rewrite it after sleeping on it.

I also realized that async112 has not been detecting

async def foo():
    async with trio.open_nursery() as nursery:
        await nursery.start(bar)

and only worked properly on start_soon.

Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this as clean improvement over the status quo; happy to take cleanups in a future PR if that works for you?

Also doesn't looks like this includes a fix for the await nursery.start(...) issue you mentioned; if I'm right either fix here or open a tracking issue?

@jakkdl
Copy link
Member Author

jakkdl commented May 3, 2024

oops, forgot to push the 112 stuff

@Zac-HD Zac-HD merged commit 126eab4 into python-trio:main May 3, 2024
10 checks passed
@jakkdl jakkdl deleted the taskgroup_support branch May 3, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants