ASYNC100 no longer triggers on context managers containing a yield
#228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh that's why, it wasn't finished x) |
|
|
Zac-HD
approved these changes
Apr 3, 2024
Comment on lines
+119
to
+122
| # Don't trigger for blocks with a yield statement | ||
| async def foo(): | ||
| with trio.fail_after(1): | ||
| yield |
There was a problem hiding this comment.
Ah. This should indeed be allowed by ASYNC100...
...but now I'm wondering about a non-optional rule to warn when you yield across a known cancelscope and the function isn't a context-manager, because that really doesn't work. Probably not worth the trouble, since njs and I are planning to get runtime enforcement, the rule would have many missed alarms, and ASYNC900 covers it anyway for people who care.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I .. don't know why I didn't open a PR when pushing this branch. fixes #224