Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pre-commit.ci, remove workflow step running pre-commit. Add pyright to CI workflow #204

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Feb 21, 2024

Some minor shuffling around of things now that we have pre-commit.ci
A bit ugly to duplicate the typing dependencies, but since we don't pin those it's nbd.

pyright is in pre-commit primarily because I run it locally, but the pre-commit bot will now also bump versions of it, causing it to actually run in the CI action, and everything magically works out.

todo:

  • edit the branch protection rules. Will do that just before merging.

@jakkdl
Copy link
Member Author

jakkdl commented Feb 21, 2024

ignoring queueing time, pyright action took 18s and pre-commit took 12.1s. Solid improvement over the old check step that took 1m24s as it didn't have access to caching for pre-commit hooks

Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but since transferring the repo I don't have permissions to edit the branch protection rules 😅

@jakkdl
Copy link
Member Author

jakkdl commented Feb 22, 2024

I do 😁

@jakkdl
Copy link
Member Author

jakkdl commented Feb 22, 2024

Removed check requirement, added 3.12, pyright, and pre-commit.

@jakkdl jakkdl merged commit dffdf7d into python-trio:main Feb 22, 2024
9 checks passed
@jakkdl jakkdl deleted the precommit branch February 22, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants