Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use startswith with tuple #959

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

nijel
Copy link
Member

@nijel nijel commented Jan 6, 2025

Proposed changes

This allows to join multiple lookups.

Types of changes

Please check the type of change your PR introduces:

  • Release (new release request)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

Other information

Any other information that is important to this PR such as screenshots of how
the component looks before and after the change.

This allows to join multiple lookups.
@nijel nijel self-assigned this Jan 6, 2025
@nijel nijel enabled auto-merge (rebase) January 6, 2025 14:21
@nijel nijel merged commit e3332e8 into python-social-auth:master Jan 6, 2025
7 of 8 checks passed
@nijel nijel deleted the startswith branch January 6, 2025 14:23
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.91%. Comparing base (326d4b3) to head (c9e5e31).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
+ Coverage   77.88%   77.91%   +0.02%     
==========================================
  Files         347      347              
  Lines       10669    10678       +9     
  Branches      504      452      -52     
==========================================
+ Hits         8310     8320      +10     
- Misses       2200     2201       +1     
+ Partials      159      157       -2     
Flag Coverage Δ
unittests 77.91% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant