Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set redirect_state to False for box backend #887

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

Arnautt
Copy link
Contributor

@Arnautt Arnautt commented Feb 19, 2024

Proposed changes

Set redirect_state parameter to False for Box backend as Box recognise the state parameter.

Types of changes

Please check the type of change your PR introduces:

  • Release (new release request)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

Other information

Any other information that is important to this PR such as screenshots of how
the component looks before and after the change.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.77%. Comparing base (d216c96) to head (7ee60e3).
Report is 3 commits behind head on master.

❗ Current head 7ee60e3 differs from pull request most recent head 4235710. Consider uploading reports for the commit 4235710 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #887   +/-   ##
=======================================
  Coverage   77.77%   77.77%           
=======================================
  Files         347      347           
  Lines       10606    10607    +1     
  Branches      699      699           
=======================================
+ Hits         8249     8250    +1     
  Misses       2200     2200           
  Partials      157      157           
Flag Coverage Δ
unittests 77.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nijel nijel merged commit 7eb6c06 into python-social-auth:master Apr 25, 2024
7 checks passed
@nijel
Copy link
Member

nijel commented Apr 25, 2024

Merged, thanks for your contribution!

@nijel nijel self-assigned this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants