Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure AD B2C base URL to match updated endpoints #777

Merged
merged 4 commits into from
Mar 30, 2023

Conversation

zchoate
Copy link
Contributor

@zchoate zchoate commented Mar 21, 2023

Proposed changes

This is similar to PR 459. I kept the policy name as an extra argument. This appears to be the default endpoint suggested by Azure AD B2C which is probably less confusing. I also made the b2clogin.com endpoint using the authority_host property. I have updated the corresponding tests as well as the docker-compose.yml to test with these Python versions: 3.6.12 3.7.16 3.8.16 3.9.16 3.10.10 3.11.2. I have documentation updates drafted and I can propose those changes if this PR is accepted.

Documentation for the endpoints can be found here: https://docs.microsoft.com/en-us/azure/active-directory-b2c/b2clogin

As proposed the base_url would be https://{tenant_name}.{authority_host}/{tenant_name}.onmicrosoft.com where tenant_name is required but authority_host will default to b2clogin.com if not set. The policy argument will still get added so an example URL for keys would look like this https://footenant.b2clogin.com/footenant.onmicrosoft.com/discovery/v2.0/keys?p=b2c_1_signin.

Types of changes

Please check the type of change your PR introduces:

  • Release (new release request)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Other information

SOCIAL_AUTH_AZUREAD_B2C_OAUTH2_TENANT_ID is updated to SOCIAL_AUTH_AZUREAD_B2C_OAUTH2_TENANT_NAME

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #777 (3c52baa) into master (d1d91ae) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #777      +/-   ##
==========================================
+ Coverage   77.34%   77.35%   +0.01%     
==========================================
  Files         325      325              
  Lines        9864     9871       +7     
  Branches     1174     1176       +2     
==========================================
+ Hits         7629     7636       +7     
  Misses       2084     2084              
  Partials      151      151              
Flag Coverage Δ
unittests 77.35% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
social_core/backends/azuread_b2c.py 82.50% <100.00%> (+1.67%) ⬆️
social_core/tests/backends/test_azuread_b2c.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nijel nijel merged commit 084cb94 into python-social-auth:master Mar 30, 2023
@nijel
Copy link
Member

nijel commented Mar 30, 2023

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants