Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instagram backend refactor #460

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

gyata97
Copy link

@gyata97 gyata97 commented May 7, 2020

Proposed changes

Instagram has deprecated most of the endpoints on api.instagram and moved all data access to graph.instagram.
Short story: Instagram Basic Display is no longer an authentication solution.
Long story: Instagram Basic Display only works on accounts that are not creator or business accounts and the endpoint will not return data (email, etc) that can be used to authenticate users. However, for creator and business accounts, the facebook backend is the authentication solution. I propose that we keep the Instagram backend for users who want to associate Instagram personal (non-creator and non-business) accounts with authenticated users. It is important to note that Facebook does not verify apps (social_core library users) that use this as an authentication method.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works

Other information

@gyata97
Copy link
Author

gyata97 commented May 7, 2020

This pull request is a response to the open issue: #419

@gyata97 gyata97 marked this pull request as draft May 9, 2020 01:29
@gyata97 gyata97 changed the title Instagram backend urls refactor Instagram backend refactor May 9, 2020
@gyata97 gyata97 marked this pull request as ready for review May 9, 2020 19:23
@stale
Copy link

stale bot commented Jul 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues (closing soon) label Jul 8, 2020
@stale stale bot closed this Jul 15, 2020
@omab omab reopened this Jan 9, 2021
@stale stale bot removed the stale Stale issues (closing soon) label Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants