Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unrestricted API for user info #363

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sposs
Copy link

@sposs sposs commented May 13, 2019

Given #335, I propose to change the URL. The default one is restricted in the number of queries per day.

Given python-social-auth#335, I propose to change the URL. The default one is restricted in the number of queries per day.
@sposs
Copy link
Author

sposs commented May 13, 2019

The tests are failing, but I can't understand why...

As the end point is not the same, the expected value was incorrect.
@sposs
Copy link
Author

sposs commented May 20, 2019

This pull request solves one issue (connection using iOS SDK with returns id_token, not access_token), but breaks the login via the /complete/google-oauth endpoint, because this uses the access_token, not the same as id_token.
Not sure how to address this in the end... Any idea?

@sposs
Copy link
Author

sposs commented May 20, 2019

Solution: try both...

@stale
Copy link

stale bot commented Mar 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues (closing soon) label Mar 22, 2020
@stale stale bot closed this Mar 29, 2020
@omab omab reopened this Jan 9, 2021
@stale stale bot removed the stale Stale issues (closing soon) label Jan 9, 2021
@sposs
Copy link
Author

sposs commented Apr 29, 2021

hello,
I've merged with Master, in the hope to have this merged eventually. Can the checks be enabled?

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #363 (6493817) into master (eeee976) will decrease coverage by 0.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #363      +/-   ##
==========================================
- Coverage   76.18%   76.16%   -0.02%     
==========================================
  Files         314      314              
  Lines        9497     9499       +2     
  Branches      465      465              
==========================================
  Hits         7235     7235              
- Misses       2110     2112       +2     
  Partials      152      152              
Flag Coverage Δ
unittests 76.16% <71.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
social_core/backends/google.py 68.18% <60.00%> (-0.87%) ⬇️
social_core/tests/backends/test_google.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeee976...6493817. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants