Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AOL OpenID auth #160

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

osya
Copy link

@osya osya commented Nov 28, 2017

Changes for the AOL OpenID auth mostly based on the corresponding LiveJournal OpenID auth code. Three tests written (according to the LiveJournalOpenIdTest). Two of them test_login and test_failed_login passed. Test test_partial_pipeline failed. IMHO it is due to wrong response message from AOL (which contains in the server_response variable in tests). For example, OpenID namespace 2.0 should be contained in this message or openid.claimed_id should be changed to to the 'openid1_claimed_id

It failed due to wrong response messages from AOL, IMHO. Comment it to pass Travis tests
@omab
Copy link
Contributor

omab commented Feb 20, 2018

@osya what's the reasoning for this change? Why drop generic openid auth with users based ones that's not backward compatible?

@osya
Copy link
Author

osya commented Feb 21, 2018

@omab, the reason for this change is just existing code for AOL OpenID in the module aol.py is not worked. I began investigate it and in the end write this PR. With my changes AOL OpenID worked somehow (two of three tests written by me according to the tests for LiveJournalOpenIdTest - passed).

@stale
Copy link

stale bot commented Mar 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale issues (closing soon) label Mar 22, 2020
@stale stale bot closed this Mar 29, 2020
@omab omab reopened this Jan 9, 2021
@stale stale bot removed the stale Stale issues (closing soon) label Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants