Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PartialMixin.next_step type annotation #1023

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

nsoranzo
Copy link
Contributor

Proposed changes

Also:

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

Also:
- Improve annotation of `PartialMixin.data`
- Remove unused `user` attribute of `UserMixin`, which may create
  type annotation conflicts in derived classes:
  galaxyproject/galaxy#19617
@nijel nijel enabled auto-merge (rebase) February 17, 2025 13:03
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.15%. Comparing base (326d4b3) to head (a2e8922).
Report is 87 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1023      +/-   ##
==========================================
+ Coverage   77.88%   78.15%   +0.26%     
==========================================
  Files         347      348       +1     
  Lines       10669    10766      +97     
  Branches      504      457      -47     
==========================================
+ Hits         8310     8414     +104     
+ Misses       2200     2192       -8     
- Partials      159      160       +1     
Flag Coverage Δ
unittests 78.15% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nijel nijel merged commit 813c2c6 into python-social-auth:master Feb 17, 2025
12 checks passed
@nijel nijel self-assigned this Feb 17, 2025
@nijel
Copy link
Member

nijel commented Feb 17, 2025

Merged, thanks for your contribution!

@nsoranzo nsoranzo deleted the type_annot_fixes branch February 19, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants