Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed rollback of extra_data migration #626

Merged

Conversation

niklas-scholz
Copy link
Contributor

@niklas-scholz niklas-scholz commented Oct 28, 2024

Proposed changes

The extra_data json field migration 0013_migrate_extra_data.py was not revertable since the is_text_field type check was throwing a TypeError since the first argument is an instance instead of a class. This error occurs only when reverting migrations on databases other than SQLite.

Types of changes

Please check the type of change your PR introduces:

  • Release (new release request)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (PEP8, lint, formatting, renaming, etc)
  • Refactoring (no functional changes, no api changes)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build related changes (build process, tests runner, etc)
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.72%. Comparing base (fb93814) to head (6769fb7).
Report is 62 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #626   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files          39       40    +1     
  Lines        1172     1185   +13     
  Branches      144       77   -67     
=======================================
+ Hits         1075     1087   +12     
- Misses         72       73    +1     
  Partials       25       25           
Flag Coverage Δ
unittests 91.72% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nijel nijel linked an issue Oct 30, 2024 that may be closed by this pull request
@nijel nijel self-assigned this Oct 30, 2024
@nijel nijel merged commit ccd740a into python-social-auth:master Oct 30, 2024
10 checks passed
@nijel
Copy link
Member

nijel commented Oct 30, 2024

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

TypeError when reverting extra_data migration 0013_migrate_extra_data
2 participants