Fix multiform bug #403
Open
Fix multiform bug #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 3, 2022 00:09
-expected result is for swagger to interpret the api as consuming only 'multipart/form-data' -this result will fail in original implementation
gilisland
reviewed
Jan 16, 2022
| @@ -466,7 +466,7 @@ def serialize_operation(self, doc, method): | |||
| doc_params = list(doc.get("params", {}).values()) | |||
| all_params = doc_params + (operation["parameters"] or []) | |||
| if all_params and any(p["in"] == "formData" for p in all_params): | |||
| if any(p["type"] == "file" for p in all_params): | |||
| if any(p["type"] == "file" or (p["type"]=="array" and p["collectionFormat"]=="multi") for p in all_params): | |||
gilisland
approved these changes
Jan 16, 2022
gilisland
approved these changes
Jan 16, 2022
| @@ -769,6 +769,25 @@ def get(self): | |||
| assert "consumes" in op | |||
| assert op["consumes"] == ["multipart/form-data"] | |||
|
|
|||
| def test_parser_parameter_in_files_appended(self, api, client): | |||
|
@SteadBytes @a-luna @j5awry @ziirish can trouble one of you to look thru this PR? Thanks! |
|
Was wondering if someone could approve this merge request so that uploads through restx work? Been having a tough time |
amloren1
approved these changes
May 6, 2022
phamhunglam
approved these changes
Jul 25, 2022
ziirish
force-pushed
the
master
branch
2 times, most recently
from
0db7d06
to
4eaf373
Compare
|
Looks like this got approved and pushed somewhere, but ultimately never got merged? |
|
Does anyone know if this fix will be merged? |
|
@gerardoemr @pbaylies Thanks for bumping this, I will try and get it merged over the weekend and released if it's something you need! |
|
Someone has updates on this PR? It would be great if it's merged to the main code base.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug where Swagger does not interpreting an API consuming an array of files, as requiring the request to be a multipart-form. Others have reflected this problem, e.g. #177.
To fix this, this PR makes the following changes over 2 commits.
swagger.pyto fix the bug. This passes the expanded test suite above.