Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an all-groups option to export such that export will handle exporting all groups #294

Merged
merged 8 commits into from
Sep 1, 2024
Merged

Add an all-groups option to export such that export will handle exporting all groups #294

merged 8 commits into from
Sep 1, 2024

Conversation

Jiafi
Copy link
Contributor

@Jiafi Jiafi commented Aug 16, 2024 •
edited
Loading

Add an --all-groups options to the exported such that users can export all the groups in the pyproject.toml file.

Also adds some error handling when it is used in conjunction with the --with flag.

Replaces #105

radoering
radoering requested changes Aug 24, 2024
View reviewed changes
Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would just change the wording of the description and we should add the new option to the readme and the docs.

src/poetry_plugin_export/command.py Outdated Show resolved Hide resolved
@Jiafi Jiafi requested a review from radoering August 26, 2024 17:26
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 1, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@radoering radoering merged commit 3610df5 into python-poetry:main Sep 1, 2024
17 checks passed
@radoering radoering mentioned this pull request Sep 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrouly jrouly jrouly approved these changes

@radoering radoering radoering approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jiafi @jrouly @radoering @KotlinIsland