release: bump version to 1.8.0 #262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimbleby
reviewed
Mar 6, 2024
pyproject.toml
Outdated
| @@ -1,14 +1,12 @@ | |||
| [tool.poetry] | |||
| name = "poetry-plugin-export" | |||
| version = "1.6.0" | |||
| version = "1.8.0" | |||
There was a problem hiding this comment.
why not 1.7.0? there is no need to keep the plugin version synchronized with the poetry version
skipping a version will just cause people to raise issues asking why
| @@ -20,8 +18,7 @@ include = [ | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = "^3.8" | |||
| poetry = "^1.6.0" | |||
| poetry-core = "^1.7.0" | |||
| poetry = "^1.8.0" | |||
There was a problem hiding this comment.
this plugin imports directly from poetry-core, so it should explicitly depend on it
There was a problem hiding this comment.
Ahh, I was trying to find the import but didn't see it, let me fix that.
There was a problem hiding this comment.
Omg... searched for the wrong import string, too much js ugh
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.