Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve warning message when lockfile is not up-to-date #215

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

jugmac00
Copy link
Contributor

For people not very familiar with poetry, it was not clear what "run update" means.

"run poetry update" makes this obvious.

Copy link
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, dependencies may not only be outdated but just wrong considering the pyproject.toml file and poetry lock --no-update may be suited better than poetry update. (If you just want to make the lock file consistent to pyproject.toml without trying to update all dependencies.) IMO, we should use the same wording as for poetry install: https://github.com/python-poetry/poetry/blob/c719dcedb8b39965bb03e69cee63129a18143331/src/poetry/installation/installer.py#L248-L254

@sonarcloud
Copy link

sonarcloud bot commented Jun 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jugmac00
Copy link
Contributor Author

jugmac00 commented Jun 25, 2023

@radoering Thanks for you fast feedback. I have updated the warning and the commit message.

Please let me know if there is anything else I should do.

@radoering radoering merged commit 62b8f1f into python-poetry:main Jun 25, 2023
17 checks passed
@jugmac00 jugmac00 deleted the improve-warning branch June 25, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants