Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make AUTHOR_REGEX less restrictive #517

Merged

Conversation

finswimmer
Copy link
Member

@finswimmer finswimmer commented Nov 1, 2022

https://packaging.python.org/en/latest/specifications/core-metadata/#author makes no restriction to the Author name. So this PR makes the regex less restrictive. It also removes a duplication of the regex.

Resolves: python-poetry/poetry#6857
Resolves: python-poetry/poetry#6933

@finswimmer finswimmer force-pushed the fix/less-restrictive-author-regex branch 3 times, most recently from 0187a3b to b329759 Compare November 1, 2022 18:54
@finswimmer finswimmer marked this pull request as ready for review November 1, 2022 18:54
@finswimmer finswimmer requested a review from a team November 1, 2022 18:55
@finswimmer finswimmer force-pushed the fix/less-restrictive-author-regex branch from b329759 to 9c071bb Compare November 1, 2022 18:56
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Secrus Secrus added the 2.0 PRs for core 2.0 label Oct 6, 2024
@finswimmer finswimmer force-pushed the fix/less-restrictive-author-regex branch from 9c071bb to ad175f8 Compare October 25, 2024 19:47
@finswimmer finswimmer force-pushed the fix/less-restrictive-author-regex branch from ad175f8 to 788682c Compare October 25, 2024 19:48
@finswimmer finswimmer requested a review from a team October 25, 2024 19:59
@Secrus Secrus merged commit 06ec909 into python-poetry:main Oct 27, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 PRs for core 2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Author Regex Too Restrictive Invalid author prevents package from being installed
2 participants