Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trivia questions #1467

Merged
merged 6 commits into from
Mar 23, 2024

Conversation

jonathan-d-zhang
Copy link
Contributor

Relevant Issues

Closes #1459

Description

Added questions to the trivia question json.

Did you:

Before, the answer '2^31-2' would have been rejected, even though "2^31
- 2" is a correct answer. This commit makes sure that we accept a decent
  variety of space combinations.
@jonathan-d-zhang jonathan-d-zhang marked this pull request as draft February 24, 2024 00:55
@jonathan-d-zhang jonathan-d-zhang marked this pull request as ready for review February 24, 2024 01:07
@Xithrius Xithrius added area: frontend Related to output and formatting status: needs review Author is waiting for someone to review and approve type: enhancement Changes or improvements to existing features category: fun Related to fun and games category: content Internal storage being updated labels Mar 8, 2024
They aren't part of the type name, so they should be outside.
Also reword existing `re` cache question to specify the unit.
@Xithrius Xithrius enabled auto-merge (squash) March 23, 2024 02:09
Copy link
Member

@Xithrius Xithrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YEP

@Xithrius Xithrius removed the status: needs review Author is waiting for someone to review and approve label Mar 23, 2024
@Xithrius Xithrius merged commit 263fbf1 into python-discord:main Mar 23, 2024
4 checks passed
@jonathan-d-zhang jonathan-d-zhang deleted the add-trivia-questions branch March 23, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: frontend Related to output and formatting category: content Internal storage being updated category: fun Related to fun and games type: enhancement Changes or improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New trivia questions
3 participants