-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trivia questions #1467
Merged
Xithrius
merged 6 commits into
python-discord:main
from
jonathan-d-zhang:add-trivia-questions
Mar 23, 2024
Merged
Add trivia questions #1467
Xithrius
merged 6 commits into
python-discord:main
from
jonathan-d-zhang:add-trivia-questions
Mar 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, the answer '2^31-2' would have been rejected, even though "2^31 - 2" is a correct answer. This commit makes sure that we accept a decent variety of space combinations.
Xithrius
added
area: frontend
Related to output and formatting
status: needs review
Author is waiting for someone to review and approve
type: enhancement
Changes or improvements to existing features
category: fun
Related to fun and games
category: content
Internal storage being updated
labels
Mar 8, 2024
They aren't part of the type name, so they should be outside.
wookie184
approved these changes
Mar 20, 2024
Xithrius
reviewed
Mar 23, 2024
Also reword existing `re` cache question to specify the unit.
Xithrius
approved these changes
Mar 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YEP
Xithrius
removed
the
status: needs review
Author is waiting for someone to review and approve
label
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: frontend
Related to output and formatting
category: content
Internal storage being updated
category: fun
Related to fun and games
type: enhancement
Changes or improvements to existing features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Closes #1459
Description
Added questions to the trivia question json.
Did you: