Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a space before "tree" in the "christmas" tree holiday reaction #1404

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add a space before "tree" in the "christmas" tree holiday reaction #1404

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1871a06
Replace or with space in christmas tree holiday reaction
shenanigansd Dec 2, 2023
f037d4d
Add the or back in, but keep the space
shenanigansd Dec 2, 2023
ad639d7
Merge branch 'main' into shenanigansd-patch-1
shenanigansd Jan 30, 2024
d4ae0cd
Only flag on Christmas trees
shenanigansd Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bot/exts/holidays/holidayreact.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class Holiday(NamedTuple):
}
)
Christmas = Holiday([Month.DECEMBER], {
"christmas tree": Trigger(r"\b((christ|x)mas|tree)\b", ["\U0001F384"]),
"christmas tree": Trigger(r"\b(christ|x)mas\s?(tree(s)?)?\b", ["\U0001F384"]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the parens around the s for pluralizing "tree" are unnecessary, but it might be slightly more readable with them

"reindeer": Trigger(r"\b(reindeer|caribou|buck|stag)\b", ["\U0001F98C"]),
"santa": Trigger(r"\bsanta\b", ["\U0001F385"]),
"snowflake": Trigger(r"\b(snow ?)?flake(?! ?8)\b", ["\u2744\uFE0F"]),
Expand Down
Loading