Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pydantic 2.0 #1321

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Update to pydantic 2.0 #1321

merged 1 commit into from
Nov 25, 2023

Conversation

wookie184
Copy link
Contributor

Currently this doesn't work due to pydantic/pydantic-settings#106. A PR fixing that was merged so just waiting for a release.

@wookie184
Copy link
Contributor Author

I'll also change it to use the class kwarg to set the env_prefix now that will be supported, since it looks pretty neat pydantic/pydantic-settings#110

@wookie184 wookie184 marked this pull request as ready for review August 20, 2023 17:09
Copy link
Member

@ChrisLovering ChrisLovering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one thing that we could change, but my approval stands either way

bot/constants.py Outdated Show resolved Hide resolved
@Xithrius Xithrius enabled auto-merge (squash) November 25, 2023 22:15
@ChrisLovering ChrisLovering merged commit 9fa1fb3 into main Nov 25, 2023
4 checks passed
@ChrisLovering ChrisLovering deleted the upgrade-pydantic-2 branch November 25, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants