Use the same pride facts for each year #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisLovering
force-pushed
the
fix-pride-facts
branch
from
d0aa5fa
to
b0dc052
Compare
Xithrius
approved these changes
Jun 30, 2023
wookie184
requested changes
Jul 8, 2023
| await self.send_random_fact(ctx) | ||
| else: | ||
| await ctx.send(embed=self.get_fact_embed()) | ||
| elif isinstance(option, int): |
There was a problem hiding this comment.
This needs to be before the previous check, otherwise .lower() will be called on the integer and cause an error.
There was a problem hiding this comment.
Good point, fixed in forcepush
ChrisLovering
force-pushed
the
fix-pride-facts
branch
from
b0dc052
to
ab551fa
Compare
The command args have been changed to accept a number between 1 & 20, rather than a date, to make it easier to select which day of the week you want. This also updates the output of the command so that the selected day, or random is included in the title.
ChrisLovering
force-pushed
the
fix-pride-facts
branch
from
ab551fa
to
b8251c3
Compare
wookie184
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command args have been changed to accept a number between 1 & 20, rather than a date, to make it easier to select which day of the week you want. This also updates the output of the command so that the selected day, or random is included in the title.