Store a MD5 hash of content for stored messages #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisLovering
requested changes
Sep 10, 2024
|
|
||
| def upgrade() -> None: | ||
| """Apply the current migration.""" | ||
| op.add_column("messages", sa.Column("content_hash", sa.String(), nullable=False)) |
There was a problem hiding this comment.
You'll need to either define a default value here, or add a migration so that existing rows meet the NOT NULL constraint added by setting nullable=False here
jb3
force-pushed
the
jb3/features/content-hash
branch
from
6fc204b to
bfa0ae3
Compare
jb3
force-pushed
the
jb3/features/content-hash
branch
from
bfa0ae3 to
e433585
Compare
ChrisLovering
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing an MD5 hash of content allows us to perform tasks related to the content of identical messages without compromising our promise of privacy and not storing actual user generated content.
With this field, we can: