Flamboyant Flamingos #16
Conversation
Alt-F4 saving skeleton proven working
- Replaced requirements.txt with Pipfile so that it works with pipenv - Moved and renamed the main python file to fit the original project layout
Starwort
force-pushed
the
master
branch
3 times, most recently
from
63b21b9
to
78a71a3
Compare
…mproves the linting apparently
Fix late binding of callback functions
Plus edited .gitignore to omit VS Code settings
This does almost nothing at the moment, but will aid in organising the rest of the program Added a key bind
Also implemented the kata as references into the main file
- Added the main base of the program - including the Canvas and the Entry Section. - Installed Pillow to be used for the Canvas sections since Canvases can't be turned into images - Added new locale phrases (for Star to translate) to the locale file - Changed the save function to write to a file instead of just printing out the file path
- Alter Individual Pixel - Alter Block Pixel - Alter Colour - Do Nothing - Pixelate
visualisation window doesn't quite work though
This does actually work - it's just a royal pain in the ass - which is exactly what it's supposed to be :)
- Added more notes to README.md - Added a JUDGEINFO.md to allow the judges to see what we actually have done that isn't troll-based - Last minute locale fix - Idk the Pipfile.lock hash changed so I thought let's add it just in case WE'VE BEEN FLAMBOYANT FLAMINGOS AND GOODNIGHT
Sorry we noticed spelling mistakes so we couldn't end off like that
Grammar errors.... oops :D
|
Mistake in JUDGEINFO.md: Top left is that's all lol |
| try: | ||
| int(colour) | ||
| except ValueError: | ||
| raise TypeError |
There was a problem hiding this comment.
this is a bit of an antipattern. you should raise this error with a message explaining what's happening, or it becomes very frustrating to debug.
There was a problem hiding this comment.
I'll leave this one to @Suhail6inkling , who wrote this code.
|
This looks like a really fun project. Great documentation, although your use of comments is a bit inconsistent - some places you've got one comment every 2 or 3 lines, while other places have neither docstrings nor block comments, and not much in the way of newlines either. Perhaps this boils down to difference in style between team members. Ideally we would have liked to see a consistent style across the entire project. Uses some older Python techniques such as Using async is a brave choice, but it's clear that you guys know what you're doing with it. I'm looking forward to testing it, and it will be interesting to see how performant it is. |
|
Thank you for the praise, it was enjoyable to create and I look forward to seeing you find all its, let's call them quirks. The reason maps and loops were used over comprehensions is almost entirely so that the asynchronous framework could work correctly - maps are faster and loops can have async microsleeps so that the framework can work at the same time. |
Did I do this right?