This repository has been archived by the owner on Mar 31, 2020. It is now read-only.
Knowledgeable Kois #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create filename.py
the 'add' button now works :0
…es for the clipboard objects and ensuring that the center widget is responsive
random_spelling_mistakes done :P
…oes not have members??
…add data and the config file location
…e-jam-4 into develop Remove unnecessary dependencies in the Pipfile and remove Text.py now that it has been split up
…recursively calling itself
…e-jam-4 into develop
…e-jam-4 into develop
|
A very interesting looking project. Code quality is overall pretty good. Not all functions and classes have docstrings which would be nice, but you have included sphinx which is a nice touch. Quite a few of the existing comments were rather odd and I didn't understand a few of them. I found a docstring in the middle of a function which would be better suited as a block comment I think. Attribute management in the classes was nice and your plugin system was very nice. Lots of the code relating to stacks was a bit messy and I found it hard to interpret. Some commented out code which should be removed and conflicting configuration of paths. This looks like a very interesting project and I look forward to testing it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.