Extend td04test ref6 #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- corrected transform.pyf, to not allocate zero-dim matrices - added tests for td04ad, one static, one checked against Octave with a transfer function set.
and works for 'C' as well as 'R' added a few tests
use conda-supplied compilers in meta.yaml fix flags for build on osx, specifically conda has python symbols in executable, needs -undefined dynamic_lookup
murrayrm
reviewed
Jul 8, 2018
| @@ -21,6 +21,13 @@ requirements: | |||
| # this link needed quite some searching, please do not delete! | |||
| # https://go.microsoft.com/fwlink/?LinkId=532606&clcid=0x409 | |||
|
|
|||
| build: | |||
There was a problem hiding this comment.
This build section is repeated from above. Should be deleted, right?
There was a problem hiding this comment.
Right. Don't know how that got cloned. Checking locally and then committing.
|
Can you pull out the While you are at it, perhaps squash the commits into a single commit, to keep it cleaner? (We can also do that on merge, if it is a hassle.) |
Closed
|
abandoning this mess of commits! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended the test cases with the case in issue #6