Remove tests_isolated from default tests run with pytest #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to prevent pytest from running tests together which need to be isolated. In the future we should try to fix these tests so they don't need to be run isolated from others.
While this bug won't impact cmd2 development itself, it will create chaos for consumers such as Linux distros trying to execute cmd2 tests when packaging it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
tests_isolatedfrom default tests run withpytestwhen run by itself on the whole directory and not usinginv pytest.This is to prevent
pytestfrom running tests together which need to be isolated and avoiding confusion for consumers such as Linux distros.In the future we should try to fix these tests so they don't need to be run isolated from others.