Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle absent lzma library #1318

Merged
merged 3 commits into from
Sep 15, 2024
Merged

Conversation

stephenfin
Copy link
Contributor

The lzma library may be missing in some environments as it is an optional dependency [1]. Fall back to bz2 in this instance.

[1] https://devguide.python.org/getting-started/setup-building/

The lzma library may be missing in some environments as it is an
optional dependency [1]. Fall back to bz2 in this instance.

[1] https://devguide.python.org/getting-started/setup-building/

Signed-off-by: Stephen Finucane <[email protected]>
cmd2/cmd2.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.72%. Comparing base (afa8019) to head (ff46021).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
cmd2/cmd2.py 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1318      +/-   ##
==========================================
- Coverage   98.52%   97.72%   -0.81%     
==========================================
  Files          22       22              
  Lines        5782     5753      -29     
==========================================
- Hits         5697     5622      -75     
- Misses         85      131      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmvanbrunt
Copy link
Member

@osfrickler I went ahead and made the suggested changes since the function needed to be refactored a bit.
Let me know if my changes match your intentions.

@kmvanbrunt kmvanbrunt added this to the 2.5.0 milestone Sep 13, 2024
@kmvanbrunt kmvanbrunt merged commit b82117c into python-cmd2:master Sep 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants