This repository has been archived by the owner on Dec 22, 2020. It is now read-only.
[WIP] Frames #14
Open
[WIP] Frames #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything is currently untested, in the wrong place, and lacking comments. It's a work in progress to look at implementing Frames in idiomatic Python, to be cleaned up and refactored before it's ever merged.
|
I added the |
The parametrization was very useful while writing the rotation code, but it slows down the tests too much now that they pass.
Using __getattr__ is slow for FrameProxy, so now inherits from AbstractFrame and implements proxy properties directly.
The FrameProxy now uses a function to register the factory function, which is cleaner. I didn't want to have
@FrameProxy
def GCRF():
return Frame(...)
since that isn't as clear reading the source that GCRF is a FrameProxy.
Tested with pytest-benchmark.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in very early stages, as I say in one of the commit messages:
I can't stress how un-tested this is: some of the code hasn't even touched the interpreter.
I intend to work on it in this branch, so others can have a look at the implementation as it develops. I welcome your criticism!