add workers arg to CLI #496
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #496 +/- ##
==========================================
- Coverage 96.27% 95.77% -0.51%
==========================================
Files 11 11
Lines 1074 1088 +14
Branches 209 195 -14
==========================================
+ Hits 1034 1042 +8
- Misses 19 23 +4
- Partials 21 23 +2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
fix test add workers arg to CLI fix test try again add sleep
|
The test seems to not be deterministic, open to suggestions on how to fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new integer argument,
--workers(or-w), to the CLI. This will cause N-1 additional worker processes to be spawned with the same configuration. This should be useful for the common case where more than one worker per machine/container is desired.Usage
This also works with the
--watchflag: all workers will be restarted upon the detection of changes.