Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] xdist custom bin packing #930

Closed
wants to merge 83 commits into from
Closed

Conversation

roddajohn
Copy link

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Make sure to include reasonable tests for your change if necessary

  • We use towncrier for changelog management, so please add a news file into the changelog folder following these guidelines:

    • Name it $issue_id.$type for example 588.bugfix;

    • If you don't have an issue_id change it to the PR id after creating it

    • Ensure type is one of removal, feature, bugfix, vendor, doc or trivial

    • Make sure to use full sentences with correct case and punctuation, for example:

      Fix issue with non-ascii contents in doctest text files.
      

@roddajohn roddajohn changed the title xdist custom bin packing [WIP] xdist custom bin packing Jul 11, 2023
@RonnyPfannschmidt
Copy link
Member

RonnyPfannschmidt commented Jul 12, 2023

This seems like a attempt for something larger

It's critical to have some design discussion and buy in from the maintainers to avoid doing a great amount of work that turns out unmerged

@nicoddemus
Copy link
Member

It's critical to have some design discussion and buy in from the maintainers to avoid doing a great amount of work that turns out unmerged

Definitely. I will close the PR for now to stop the stream of notifications.

@nicoddemus nicoddemus closed this Jul 12, 2023
@roddajohn
Copy link
Author

Oh sorry y'all, honestly was just looking for the diff.

@nicoddemus
Copy link
Member

For that you might open a PR to your own fork's master branch. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants