Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid triggering @property methods on plugins when looking for hookimpls during registration #536

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Avoid triggering @property methods on plugins when looking for hookimpls during registration #536

wants to merge 8 commits into from

Commits on Sep 27, 2024

  1. Avoid triggering property methods when inspecting plugin attribute si… 

    …gnatures
    @pirate
    pirate committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    24895d0 View commit details
    Browse the repository at this point in the history

  2. Add exception handler to deal with proxy object attrs as well

    @pirate
    pirate committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    aae3799 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. remove pydantic-specific logic and support hookspecs too 

    updates:
- [github.com/astral-sh/ruff-pre-commit: v0.6.7 → v0.6.8](astral-sh/ruff-pre-commit@v0.6.7...v0.6.8)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci
    @pirate
    pirate committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    90d9f80 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into patch-1

    @pirate
    pirate authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    61a9a86 View commit details
    Browse the repository at this point in the history

  3. explicitly test that properties are ignored on both classes and insta… 

    …nces
    @pirate
    pirate committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2536c62 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. swap _attr_is_property arg Any type to object type 

    Co-authored-by: Ran Benita <[email protected]>
    @pirate @bluetech
    pirate and bluetech authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    c0789a6 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Return None instead of falling back to getattr(type(plugin))

    @pirate
    pirate authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    bfe9f91 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into patch-1

    @pirate
    pirate authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    16a2344 View commit details
    Browse the repository at this point in the history