Skip to content

Enable some tests in CI or offline, remove refurb. #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ repos:
hooks:
- id: ruff-format
- id: ruff
- repo: https://github.com/dosisod/refurb
rev: v2.0.0
hooks:
- id: refurb
- repo: https://github.com/executablebooks/mdformat
rev: 0.7.22
hooks:
Expand Down
4 changes: 3 additions & 1 deletion docs/source/changes.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ chronological order. Releases follow [semantic versioning](https://semver.org/)
releases are available on [PyPI](https://pypi.org/project/pytask) and
[Anaconda.org](https://anaconda.org/conda-forge/pytask).

## 0.5.3 - 2025-xx-xx
## 0.5.3 - 2025-05-16

- {pull}`650` allows to identify from which data catalog a node is coming from. Thanks
to {user}`felixschmitz` for the report! The feature is enabled by adding an
Expand All @@ -15,6 +15,8 @@ releases are available on [PyPI](https://pypi.org/project/pytask) and
- {pull}`671` enhances the documentation on complex repetitions. Closes {issue}`670`.
- {pull}`673` adds de-/serializer function attributes to the `PickleNode`. Closes
{issue}`669`.
- {pull}`677` excludes the latest click v8.2.0 due to compatibility issues.
- {pull}`678` enables some tests in CI or offline, removes refurb.

## 0.5.2 - 2024-12-19

Expand Down
8 changes: 0 additions & 8 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ source = "vcs"
allow-direct-references = true

[tool.ruff]
target-version = "py39"
fix = true
unsafe-fixes = true
extend-include = ["*.ipynb"]
Expand Down Expand Up @@ -197,13 +196,6 @@ disable_error_code = ["import-not-found"]
module = ["_pytask.hookspecs"]
disable_error_code = ["empty-body"]

[tool.refurb]
python_version = "3.9"

[[tool.refurb.amend]]
path = "src/_pytask/mark/structures.py"
ignore = ["FURB173"]

[tool.coverage.report]
exclude_also = [
"pragma: no cover",
Expand Down
4 changes: 2 additions & 2 deletions tests/test_debugging.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def task_example():


@pytest.mark.end_to_end
@pytest.mark.xfail(reason="#312")
@pytest.mark.xfail(os.environ.get("CI") == "true", reason="#312")
@pytest.mark.skipif(not IS_PEXPECT_INSTALLED, reason="pexpect is not installed.")
@pytest.mark.skipif(sys.platform == "win32", reason="pexpect cannot spawn on Windows.")
def test_pdb_interaction_capturing_simple(tmp_path): # pragma: no cover
Expand Down Expand Up @@ -285,7 +285,7 @@ def task_2():


@pytest.mark.end_to_end
@pytest.mark.xfail(reason="#312")
@pytest.mark.xfail(os.environ.get("CI") == "true", reason="#312")
@pytest.mark.skipif(not IS_PEXPECT_INSTALLED, reason="pexpect is not installed.")
@pytest.mark.skipif(sys.platform == "win32", reason="pexpect cannot spawn on Windows.")
def test_pdb_interaction_capturing_twice(tmp_path): # pragma: no cover
Expand Down
4 changes: 2 additions & 2 deletions tests/test_hook_module.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
pytest.param(
True,
marks=pytest.mark.xfail(
sys.platform == "win32" and "CI" in os.environ,
sys.platform == "win32" and os.environ.get("CI") == "true",
reason="pytask is not found in subprocess",
strict=True,
),
Expand Down Expand Up @@ -64,7 +64,7 @@ def pytask_extend_command_line_interface(cli):
pytest.param(
True,
marks=pytest.mark.xfail(
sys.platform == "win32" and "CI" in os.environ,
sys.platform == "win32" and os.environ.get("CI") == "true",
reason="pytask is not found in subprocess",
strict=True,
),
Expand Down
1 change: 0 additions & 1 deletion tests/test_live.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ def test_live_execution_displays_subset_of_table(capsys, tmp_path, n_entries_in_


@pytest.mark.unit
@pytest.mark.xfail(reason="See #377.")
def test_live_execution_skips_do_not_crowd_out_displayed_tasks(capsys, tmp_path):
path = tmp_path.joinpath("task_module.py")
task = Task(base_name="task_example", path=path, function=lambda x: x)
Expand Down