Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove necessity to have mpv on windows with wsl #1389

Closed
wants to merge 1 commit into from

Conversation

victorserafim
Copy link

@victorserafim victorserafim commented Aug 2, 2024

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

Permit the WSL users install the mpv direct in wsl through apt install mpv

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@victorserafim victorserafim changed the title fix:remove necessity to have mpv on windows with wsl fix: remove necessity to have mpv on windows with wsl Aug 2, 2024
@Derisis13
Copy link
Collaborator

I find it unnecessary, as you can override the default player with the environment variable ANI_CLI_PLAYER.
But I'd like to take some input from wsl users: would you prefer to install mpv under linux or windows? I'd think windows is preferred, as it'd be better integrated with the OS - but this is all just guesswork on my part. From my experience WSL's windowing is terrible and I'd rather avoid it.

@port19x
Copy link
Collaborator

port19x commented Aug 8, 2024

I find this unnecessary as well

@port19x port19x closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants