Fetch and cache slack channels #338
Conversation
ovv
force-pushed
the
fetch-slack-channels
branch
2 times, most recently
from
65a0a6a to
ccad1c6
Compare
| logger.exception("Error refreshing slack user cache") | ||
| raise | ||
| return |
There was a problem hiding this comment.
I don't raise here because nothing else will catch it and asyncio will complains that we have an unhandled exception
pyslackersweb/tasks.py
Outdated
| channels = [] | ||
| while True: | ||
| params = {} | ||
| async with session.get( |
There was a problem hiding this comment.
We should probably add a pyslackersweb/util/slack.py utility file that does the paging and just yields the pages to us to DRY this up a little.
At some point I'd like to pull the actual HTTP logic out of the tasks, this may be a good time to do it for the slack stuff.
There was a problem hiding this comment.
Can't DRY it more than that.
I took a quick look at the slack client v2 but it would still requires a bunch of code around compared to slack-sansio
|
We can pursue #186 - we just need to answer some questions of "what defines popularity", as showing |
ovv
force-pushed
the
fetch-slack-channels
branch
2 times, most recently
from
28ae9e1 to
2e3d281
Compare
pyslackersweb/contexts.py
Outdated
| @@ -29,4 +34,5 @@ | |||
| async def client_session(app: web.Application) -> None: | |||
| async with ClientSession(raise_for_status=True) as session: | |||
| app["client_session"] = session | |||
| app["slack_client"] = SlackAPI(token=app["slack_token"], session=session) | |||
There was a problem hiding this comment.
This should be an independent context (or setup signal). It depends on this one, but shouldn't expand what the client_session cleanup_ctx does.
There was a problem hiding this comment.
I was afraid you where going to say that.
There was a problem hiding this comment.
I wasn't sure on the ordering of processing, but it looks like cleanup_ctx always is applied first on setup and cleanup:
ovv
force-pushed
the
fetch-slack-channels
branch
2 times, most recently
from
b7836d6 to
9fcc1d0
Compare
ovv
force-pushed
the
fetch-slack-channels
branch
from
9fcc1d0 to
250fad3
Compare
Relevant Issue & Description
I like the idea behind #186 and #40 . This is the first step towards thoses