Allow description, name and email to be empty #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
+ Coverage 95.97% 96.24% +0.27%
==========================================
Files 5 5
Lines 273 293 +20
==========================================
+ Hits 262 282 +20
Misses 11 11 ☔ View full report in Codecov by Sentry. |
WebReflection
previously approved these changes
Feb 14, 2024
|
I had questions but it looks like you addressed all of them ... still approved, I hope this works as expected. |
|
Thank you Andrea! Had to fight with pre-commit but is working now thanks to Matt |
mchilvers
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the create command keeps asking user for name, description and email if the user presses enter to skip it. This PR makes sure that users can now skip these config values and default to an empty string.