Updating utils.py and a few tests tolerances

pysal · Jun 24, 2024 · b4df185 · b4df185
1 parent 4fa1f67
commit b4df185
Show file tree

Hide file tree

Showing 7 changed files with 904 additions and 1,559 deletions.
diff --git a/spreg/error_sp_het.py b/spreg/error_sp_het.py
@@ -129,12 +129,6 @@ def __init__(self, y, x, w, max_iter=1, epsilon=0.00001, step1c=False, hard_boun
         else:
             lambda2 = lambda1
 
-        # Forcing the 1st step lambda to be in the range [-0.9, 0.9] to avoid perfect collinearity in step 2 in case of SLX-Error or GNS models
-        #if lambda2 > 0.9:
-        #    lambda_old = 0.9
-        #elif lambda2 < -0.9:
-        #    lambda_old = -0.9
-        #else:
         lambda_old = lambda2
 
         self.iteration, eps = 0, 1

diff --git a/spreg/ml_lag_regimes.py b/spreg/ml_lag_regimes.py
@@ -643,6 +643,8 @@ def _work(
     model.aic = DIAG.akaike(reg=model)
     model.schwarz = DIAG.schwarz(reg=model)
     model.slx_lags = slx_lags
+    model.w = w_r
+    model.rho = model.betas[-1]    
     return model
 
 

diff --git a/spreg/tests/test_error_sp_het.py b/spreg/tests/test_error_sp_het.py