Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update & test min reqs + handling upstream deprecation warnings #169

Merged
merged 7 commits into from
Nov 15, 2022

Conversation

jGaboardi
Copy link
Member

@jGaboardi jGaboardi commented Nov 15, 2022

This PR resolves #162 and resolves #170 along with other warning handling. Two other issues that need to be addressed, but can hold off for later: #167 & #168.

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #169 (cf10304) into main (8dba8c4) will increase coverage by 0.8%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #169     +/-   ##
=======================================
+ Coverage   75.7%   76.5%   +0.8%     
=======================================
  Files         19      19             
  Lines       1562    1579     +17     
=======================================
+ Hits        1182    1208     +26     
+ Misses       380     371      -9     
Impacted Files Coverage Δ
splot/_viz_esda_mpl.py 100.0% <ø> (ø)
splot/tests/test_viz_value_by_alpha_mapl.py 100.0% <ø> (ø)
splot/_viz_utils.py 60.2% <100.0%> (+3.2%) ⬆️
splot/_viz_value_by_alpha_mpl.py 96.2% <100.0%> (+0.1%) ⬆️
splot/tests/test_viz_esda_mpl.py 100.0% <100.0%> (ø)
splot/tests/test_viz_giddy_mpl.py 100.0% <100.0%> (ø)
splot/tests/test_viz_libpysal_mpl.py 100.0% <100.0%> (ø)
splot/_version.py 40.7% <0.0%> (+2.7%) ⬆️

@jGaboardi jGaboardi mentioned this pull request Nov 15, 2022
@jGaboardi jGaboardi changed the title resolves #162, etc. [WIP] resolves #162, etc. Nov 15, 2022
@jGaboardi jGaboardi added the WIP label Nov 15, 2022
@jGaboardi jGaboardi changed the title [WIP] resolves #162, etc. [WIP] resolves #162, #170, etc. Nov 15, 2022
@jGaboardi jGaboardi changed the title [WIP] resolves #162, #170, etc. resolves #162, #170, etc. Nov 15, 2022
@jGaboardi jGaboardi removed the WIP label Nov 15, 2022
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinfleis
Copy link
Member

Can you change the title of the PR so it is clear what it is doing from skimming the commit history?

@jGaboardi jGaboardi changed the title resolves #162, #170, etc. Update & test min reqs + handling upstream deprecation warnings Nov 15, 2022
@jGaboardi
Copy link
Member Author

Can you change the title of the PR so it is clear what it is doing from skimming the commit history?

Done.

@jGaboardi
Copy link
Member Author

Good to merge?

@martinfleis martinfleis merged commit 7750929 into pysal:main Nov 15, 2022
@jGaboardi jGaboardi deleted the CI_warnings_etc branch November 16, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

min supported versions address matplotlib.cmap deprecation warnings
2 participants