Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up the "slow", not compiled with numba.jit, _fisher_jenks_means by 4 to 5 times. Saves 3 minutes classifiying 8000 data points. #201

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Speed up the "slow", not compiled with numba.jit, _fisher_jenks_means by 4 to 5 times. Saves 3 minutes classifiying 8000 data points. #201

wants to merge 18 commits into from

Commits on Dec 13, 2023

  1. Deactivate CI

    @JamesParrott
    JamesParrott committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    34c7a25 View commit details
    Browse the repository at this point in the history

  2. Add _fisher_jenks_means_without_numpy and Monkey patch code.

    @JamesParrott
    JamesParrott committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    2a85d9e View commit details
    Browse the repository at this point in the history

  3. Update README.md

    @JamesParrott
    JamesParrott committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    6fac0d2 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. Monkey patch in _fisher_jenks_means_without_numpy if no Numba (even i… 

    …f Numpy)
    @JamesParrott
    JamesParrott committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    270d475 View commit details
    Browse the repository at this point in the history

  2. Only use CPython types.

    @JamesParrott
    JamesParrott committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    51a79fb View commit details
    Browse the repository at this point in the history

  3. FisherJenks now accepts _fisher_jenks_means as an injected dependency… 

    …. Remove unused HAS_NUMPY check
    @JamesParrott
    JamesParrott committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    8c44ba0 View commit details
    Browse the repository at this point in the history

  4. Add test

    @JamesParrott
    JamesParrott committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    b125267 View commit details
    Browse the repository at this point in the history

  5. Use sorted, not np.sort.astype. Compare times with and without overhead.

    @JamesParrott
    JamesParrott committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    eba2180 View commit details
    Browse the repository at this point in the history

  6. Adjust typing in docstring. Correct function name.

    @JamesParrott
    JamesParrott committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    583ae81 View commit details
    Browse the repository at this point in the history

  7. Revert "Deactivate CI" 

    This reverts commit 34c7a25.
    @JamesParrott
    JamesParrott committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    1c79a9d View commit details
    Browse the repository at this point in the history

  8. Revert README.md to original

    @JamesParrott
    JamesParrott committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    81501db View commit details
    Browse the repository at this point in the history

  9. Remove unused entry and unused import

    @JamesParrott
    JamesParrott committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    f68bd5e View commit details
    Browse the repository at this point in the history

  10. Tweak to reduce number of changes in PR

    @JamesParrott
    JamesParrott committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    9784bfd View commit details
    Browse the repository at this point in the history

  11. Remove whitespace

    @JamesParrott
    JamesParrott committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    49a06a9 View commit details
    Browse the repository at this point in the history

  12. Fix error when numba present. Add timing test that starts from np arrays

    @JamesParrott
    JamesParrott committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    dbb3b8d View commit details
    Browse the repository at this point in the history

  13. Set bins to be a numpy array

    @JamesParrott
    JamesParrott committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    0b48854 View commit details
    Browse the repository at this point in the history

  14. Change exception if numba present to a UserWarning

    @JamesParrott
    JamesParrott committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    9216462 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Make zeros an instance method and MockNumpy a Python 3 style class

    @JamesParrott
    JamesParrott committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    268c1d5 View commit details
    Browse the repository at this point in the history