-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecation of _indices #69
Conversation
Co-authored-by: James Gaboardi <[email protected]>
Should we disable doctests for the |
@sjsrey shall we pick this back up again to get CI green? |
Co-authored-by: James Gaboardi <[email protected]>
Slight issue I see is that this warning is emitted by |
Looks like have a fresh exception being thrown by bleeding edge
|
We still need to address these failures, either by skipping or updating. |
@jGaboardi that is fixed by geopandas/geopandas#3288 |
The remaining failure is related to codecov on macos-13. @jGaboardi any suggestions? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=======================================
+ Coverage 98.0% 98.2% +0.2%
=======================================
Files 4 4
Lines 301 334 +33
=======================================
+ Hits 295 328 +33
Misses 6 6
|
Seems that it's actually |
pre-commit.ci run |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
The bot is having trouble auto fixing the import sorting for some reason. Running |
pre-commit.ci autofix |
xref #67