Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix padding #179

Merged
merged 7 commits into from
Apr 9, 2024
Merged

fix padding #179

merged 7 commits into from
Apr 9, 2024

Conversation

MateoLostanlen
Copy link
Member

We use a letterbox transformation for the yolo, which adds padding to the image. This padding was not taken into account in the bounding box, resulting in an offset in the bbox displayed on the platform

@MateoLostanlen MateoLostanlen added the type: bug Something isn't working label Apr 4, 2024
@MateoLostanlen MateoLostanlen requested a review from a team April 4, 2024 20:15
@MateoLostanlen MateoLostanlen self-assigned this Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.96%. Comparing base (035c5ae) to head (92667b1).

❗ Current head 92667b1 differs from pull request most recent head 03121e7. Consider uploading reports for the commit 03121e7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #179      +/-   ##
===========================================
+ Coverage    87.87%   87.96%   +0.09%     
===========================================
  Files            6        6              
  Lines          371      374       +3     
===========================================
+ Hits           326      329       +3     
  Misses          45       45              
Flag Coverage Δ
unittests 87.96% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateoLostanlen MateoLostanlen merged commit 2cbe807 into develop Apr 9, 2024
11 of 12 checks passed
@MateoLostanlen MateoLostanlen deleted the fix_padding branch April 9, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant