Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bbox #162

Merged
merged 20 commits into from
Jul 24, 2023
Merged

Add bbox #162

merged 20 commits into from
Jul 24, 2023

Conversation

MateoLostanlen
Copy link
Member

The purpose of this PR is to transmit the detection location produced by the model, which is possible since the last api update

@MateoLostanlen MateoLostanlen requested review from a team July 18, 2023 06:49
@ghost
Copy link

ghost commented Jul 18, 2023

Nice of you to open a PR 🙏
When you're ready and want to get it reviewed, post a comment in this Pull Request with this message: /quack review

@MateoLostanlen
Copy link
Member Author

/quack review

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🙏

Other sections
  • [function-naming] detected at pyroengine/utils.py:L87
  • [argument-naming] detected at pyroengine/utils.py:L87
  • [untested] detected at pyroengine/utils.py:L13
  • [untested] detected at pyroengine/utils.py:L22
  • [untested] detected at pyroengine/utils.py:L65
  • [untested] detected at pyroengine/utils.py:L87
  • [missing-type-annotations] detected at pyroengine/utils.py:L13
  • [intermediate-variable] detected at pyroengine/utils.py:L14
  • [intermediate-variable] detected at pyroengine/utils.py:L15
  • [intermediate-variable] detected at pyroengine/utils.py:L16
  • [intermediate-variable] detected at pyroengine/utils.py:L17
  • [intermediate-variable] detected at pyroengine/utils.py:L18
  • [missing-type-annotations] detected at pyroengine/utils.py:L22
  • [missing-type-annotations] detected at pyroengine/utils.py:L65
  • [missing-type-annotations] detected at pyroengine/utils.py:L87
  • [intermediate-variable] detected at pyroengine/utils.py:L103
  • [missing-type-annotations] detected at pyroengine/vision.py:L32
  • [intermediate-variable] detected at pyroengine/vision.py:L53
  • [intermediate-variable] detected at pyroengine/vision.py:L64
  • [intermediate-variable] detected at pyroengine/vision.py:L66
  • [intermediate-variable] detected at pyroengine/vision.py:L67
  • [intermediate-variable] detected at pyroengine/engine.py:L253
  • [intermediate-variable] detected at pyroengine/engine.py:L254
  • [intermediate-variable] detected at pyroengine/engine.py:L256
  • [intermediate-variable] detected at pyroengine/engine.py:L257
  • [intermediate-variable] detected at pyroengine/engine.py:L261
  • [intermediate-variable] detected at pyroengine/engine.py:L266
  • [intermediate-variable] detected at pyroengine/engine.py:L271
  • For a better experience, it's recommended to check the review comments in the tab Files Changed.


    Feedback is a gift! Quack will adjust your review style when you add reactions to a review comment

    pyroengine/utils.py Outdated Show resolved Hide resolved
    pyroengine/utils.py Outdated Show resolved Hide resolved
    pyroengine/utils.py Outdated Show resolved Hide resolved
    pyroengine/utils.py Outdated Show resolved Hide resolved
    pyroengine/utils.py Outdated Show resolved Hide resolved
    pyroengine/engine.py Show resolved Hide resolved
    pyroengine/engine.py Show resolved Hide resolved
    pyroengine/engine.py Show resolved Hide resolved
    pyroengine/engine.py Show resolved Hide resolved
    pyroengine/engine.py Show resolved Hide resolved
    @codecov
    Copy link

    codecov bot commented Jul 19, 2023

    Codecov Report

    Merging #162 (ea63761) into develop (ee813bc) will increase coverage by 22.89%.
    The diff coverage is 86.54%.

    @@             Coverage Diff              @@
    ##           develop     #162       +/-   ##
    ============================================
    + Coverage    63.68%   86.58%   +22.89%     
    ============================================
      Files            5        6        +1     
      Lines          179      328      +149     
    ============================================
    + Hits           114      284      +170     
    + Misses          65       44       -21     
    Flag Coverage Δ
    unittests 86.58% <86.54%> (+22.89%) ⬆️

    Flags with carried forward coverage won't be shown. Click here to find out more.

    Impacted Files Coverage Δ
    pyroengine/core.py 53.84% <53.84%> (ø)
    pyroengine/engine.py 88.29% <88.29%> (ø)
    pyroengine/sensors.py 88.88% <88.88%> (ø)
    pyroengine/utils.py 95.55% <95.55%> (ø)
    pyroengine/__init__.py 100.00% <100.00%> (ø)
    pyroengine/vision.py 100.00% <100.00%> (ø)

    @MateoLostanlen MateoLostanlen merged commit d5a4d8c into develop Jul 24, 2023
    13 of 16 checks passed
    @frgfm frgfm deleted the add_bbox branch July 25, 2023 02:23
    MateoLostanlen added a commit that referenced this pull request Aug 16, 2023
    * update header (#149)
    
    * fix black (#150)
    
    * Update README.md (#151)
    
    * Promtail (#152)
    
    * Update of the main branch before the new deployment in Ardeche (#145)
    
    * ci on develop (#134)
    
    * update develop tour (#135)
    
    * fix args (#136)
    
    * fix: Fixed script arg name in src/run.py (#138)
    
    * clean backup by size (#141)
    
    * clean backup by size
    
    * black
    
    * missing deps
    
    * drop function
    
    * drop function 2
    
    * Day only (#142)
    
    * sunset_sunrise script
    
    * update output file path
    
    * check if day time
    
    * put back real api
    
    * style
    
    * use datetime timedelta
    
    * Make all params availables from run (#144)
    
    * make all params available in run
    
    * make params availables
    
    * put back api
    
    * style
    
    * put back alert_relaxation to 2
    
    * Yolov5 (#143)
    
    * switch to yolov5
    
    * missing import
    
    * style
    
    * fix tests
    
    * unused import
    
    * update readme
    
    * letterbox transform
    
    * do not resize with pillow before pred
    
    * style
    
    * downgrad opencv
    
    * wrong img name
    
    * long line
    
    * missing deps
    
    * model path
    
    * header
    
    * lib for opencv
    
    * create model folder
    
    * update init
    
    * remove hub deps
    
    * update threshold
    
    * feat: Added promtail service
    
    * feat: Added promtail config file
    
    * feat: Renamed variable
    
    * feat: Renamed vars
    
    * docs: Updated setup explanation
    
    * feat: Added restart option
    
    ---------
    
    Co-authored-by: Mateo <[email protected]>
    
    * analyze stream timeout (#153)
    
    * update docker img (#154)
    
    * add utc (#155)
    
    * fix style (#158)
    
    * Ir day night (#159)
    
    * set margin to 0
    
    * drop utc
    
    * add ir strategy
    
    * update docstring
    
    * fix style
    
    * fix missing undefinded params (#161)
    
    * Add bbox (#162)
    
    * add bbox
    
    * fix inference
    
    * style
    
    * fix vision
    
    * style vision
    
    * fix engine
    
    * keep all preds
    
    * speed up
    
    * pass dummy loc
    
    * switch to v8
    
    * fix tests
    
    * test
    
    * drop dummy test
    
    * new api version
    
    * unsed import
    
    * install git
    
    * code quality
    
    * use bbox branch
    
    * use apt get
    
    * alert relaxation 3
    
    * New alerte strategy (#164)
    
    * new alert system
    
    * fix unitests
    
    * Occlusion mask (#165)
    
    * add occlusion mask
    
    * trest mask
    
    * missing args
    
    * use cam_key
    
    * update test
    
    * add a test
    
    * clip values
    
    * install from main (#167)
    
    * limit bbox size (#166)
    
    * limit bbox size
    
    * style
    
    * use 4 frames (#168)
    
    * don't send bbox (#169)
    
    * prevent empty (#171)
    
    ---------
    
    Co-authored-by: fe51 <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant