Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psycopg dependency error #368

Closed
wants to merge 1 commit into from
Closed

Psycopg dependency error #368

wants to merge 1 commit into from

Conversation

RonanMorgan
Copy link
Collaborator

This is fixing the following error :

ModuleNotFoundError: No module named 'psycopg2'

It seems that the async driver asyncpg still has a dependency to the psycopg2 driver (for errors definition)

@RonanMorgan RonanMorgan self-assigned this Sep 13, 2024
@github-actions github-actions bot added the topic: build Related to build, installation & CI label Sep 13, 2024
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
pypi/[email protected] environment, eval, filesystem, network, shell, unsafe 0 10.6 MB piro

View full report↗︎

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.58%. Comparing base (92b9e28) to head (2b4d90c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #368   +/-   ##
=======================================
  Coverage   86.58%   86.58%           
=======================================
  Files          31       31           
  Lines         857      857           
=======================================
  Hits          742      742           
  Misses        115      115           
Flag Coverage Δ
backend 86.18% <ø> (ø)
client 91.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frgfm
Copy link
Member

frgfm commented Sep 13, 2024

Thanks for the PR! Seems like the review will be straight forward: can you specify how to reproduce the error though?
I haven't met that error neither the CI, so either we need to update the CI to reproduce that or we don't have the same environment 😅

@RonanMorgan
Copy link
Collaborator Author

RonanMorgan commented Sep 16, 2024

hum ok I think this happened because this part "+asyncpg" was not in the database URL in the production docker-compose I found so it should be ok now

@frgfm
Copy link
Member

frgfm commented Sep 20, 2024

hum ok I think this happened because this part "+asyncpg" was not in the database URL in the production docker-compose I found so it should be ok now

Ah gotcha, I'll close the PR then!

@frgfm frgfm closed this Sep 20, 2024
@frgfm frgfm deleted the rs/fix-psycopg branch September 20, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: build Related to build, installation & CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants