Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypyr v5 + python 3.10 #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yaythomas
Copy link

@yaythomas yaythomas commented Nov 21, 2021

pypyr v5 has upgraded the main API entrypoint. (I'm the maintainer of the pypyr proj, is how I happen to know 😉 )

the following breaking changes are relevant here:

  • run() replaces main()
  • the working_dir arg doesn't exist anymore. pypyr will now automatically add the pipeline's parent directory to the module resolution path, so here for this implementation just passing the path to the pipeline itself as pipeline_name is sufficient for feature parity.

Release notes here https://pypyr.io/updates/releases/v5.0.0/.

Please also double-check for breaking changes on v4.0.0 - the latest version in the previous pipfile.lock was version 3.0 still, so v4.0 breaking changes might also cause problems - release notes here https://pypyr.io/updates/releases/v4.0.0/. Especially watch if your legacy pipelines has pypyr.steps.contextset - it was deprecated then for pypyr.steps.contextcopy.

This hasn't been updated in a while, so the Pipfile was breaking build for a few dependencies in apscheduler and pytest - causing problems from completely broken install to failing tests - all resolved by just installing latest. While I was there, I moved the python version to 3.10, so please be aware and feel free to disallow if this is not suitable for your implementation support schedule and you have to support 3.8. . . while I was hoping to help by quickly making the relevant pypyr API changes for you to prevent breakages if/when you upgrade I also didn't want to throw a broken build over the fence at you so I took the path of least resistance by upgrading to latest 😄

Summary of changes:

  • pypyr v5 api upgrade to run()
  • Pipfile update Python runtime to py 3.10 and also unpin coverage dev dependency.
  • regenerate Pipfile.lock
  • travis update to py 3.10

pypyr v5 api upgrade to run()
Pipfile update Python runtime to py 3.10 and also unpin coverage dev dependency.
Update travis to py 3.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant