Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a notebook to explore sub-networks #74

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ekatef
Copy link
Member

@ekatef ekatef commented Dec 4, 2023

A simple notebook which may be useful to explore topology of isolated sub-networks.

@ekatef ekatef force-pushed the add_subnetwork_notebook branch 2 times, most recently from d4a3ed3 to 945b3a7 Compare December 4, 2023 22:37
@ekatef
Copy link
Member Author

ekatef commented Jan 24, 2024

@davide-f would you have time to review it? The idea is to have a simple tool which can be used to check topology of the resulted grid model.

Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! @ekatef :D
And quite useful for the PRs on the isolated network ones :)

The general perspective is that they are clear and the code is ok as is in my opinion, I would only add some text to describe what is being done.

I was wondering if rather than creating a new notebook, we may revise an existing one.
For example, base_network seemed a good candidate, what is your opinion?

@ekatef
Copy link
Member Author

ekatef commented Jan 26, 2024

Very nice! @ekatef :D And quite useful for the PRs on the isolated network ones :)

The general perspective is that they are clear and the code is ok as is in my opinion, I would only add some text to describe what is being done.

I was wondering if rather than creating a new notebook, we may revise an existing one. For example, base_network seemed a good candidate, what is your opinion?

Thanks a lot for reviewing @davide-f! Agree by all the points :) base_network seems to be an excellent match for this exercise. Happy to add these plots there.

Would you mind to keep this PR open in meantime? The scripts are pretty useful for quick investigation of the network topology, and sometimes I'm using this PR to quickly share the approach. (I'll do my best to avoid making this meantime getting too long!)

@davide-f
Copy link
Member

No problem :) we can definitely keep it open!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants