Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete BrowserStack references and logo image #17283

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Delete BrowserStack references and logo image #17283

merged 3 commits into from
Dec 16, 2024

Conversation

eggplants
Copy link
Contributor

@eggplants eggplants commented Dec 14, 2024

I've deleted the references of BrowserStack from README and the unused logo image docs/dev/_static/browserstack-logo.png.

@eggplants eggplants requested a review from a team as a code owner December 14, 2024 15:59
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

We probably shouldn't fix this, rather remove the callout to Browserstack completely, as we no longer have that service available.

Would you rather remove the reference? If so, please push a change to this PR and re-request a review.

@eggplants eggplants changed the title Revive dead browserstack logo Delete BrowserStack references and logo image Dec 16, 2024
miketheman
miketheman previously approved these changes Dec 16, 2024
Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

README.rst Outdated Show resolved Hide resolved
@miketheman miketheman self-requested a review December 16, 2024 16:57
@miketheman miketheman dismissed their stale review December 16, 2024 16:57

di requested changes

@di di enabled auto-merge (squash) December 16, 2024 17:02
@di di merged commit 16230a1 into pypi:main Dec 16, 2024
20 checks passed
@eggplants eggplants deleted the patch-1 branch December 16, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants